fix: no error for inline array schema when items field is a ref #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrett-schonefeld
force-pushed
the
array-schema-reference
branch
from
224b90d
to
5216114
Compare
mkistler
suggested changes
Mar 5, 2021
barrett-schonefeld
force-pushed
the
array-schema-reference
branch
from
5216114
to
ffe2c19
Compare
Purpose: - generator flattens reference to an array schema back into an inline schema Changes: - Add a check to see if the schema is an array with an items field that uses a ref - Add a check to see if the array schema has primitive type items - Add reusable isPrimitiveType function Tests: - Add tests to ensure the validator does not flag different variations of this array schema - Update expected warnings in tests that use specs with this array schema - Add test to ensure arrays with primitive-type items are not flagged - Add tests for isPrimitiveType function
barrett-schonefeld
force-pushed
the
array-schema-reference
branch
from
ffe2c19
to
681c103
Compare
dpopp07
pushed a commit
that referenced
this pull request
Mar 8, 2021
## [0.35.1](v0.35.0...v0.35.1) (2021-03-08) ### Bug Fixes * no error for inline array schema when items field is a ref ([#257](#257)) ([4dd3708](4dd3708))
|
🎉 This PR is included in version 0.35.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 9, 2021
This was referenced Mar 17, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Changes:
inline_response_schemacheck. I did not find an equivalent check for inline request bodies.Tests: